From 81b774a7f000211d07d1fd10a62a0d475483cdfa Mon Sep 17 00:00:00 2001
From: UUBulb <35923940+uubulb@users.noreply.github.com>
Date: Sun, 23 Jun 2024 22:27:23 +0800
Subject: [PATCH] fix: temperatureStat will stack up (#30)

---
 pkg/monitor/monitor.go | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/pkg/monitor/monitor.go b/pkg/monitor/monitor.go
index 4afcc46..c3e150d 100644
--- a/pkg/monitor/monitor.go
+++ b/pkg/monitor/monitor.go
@@ -7,6 +7,7 @@ import (
 	"runtime"
 	"strconv"
 	"strings"
+	"sync"
 	"sync/atomic"
 	"syscall"
 	"time"
@@ -54,6 +55,7 @@ var deviceDataFetchAttempts = map[string]int{
 var (
 	updateGPUStatus  int32
 	updateTempStatus int32
+	tempWriteLock    sync.RWMutex
 )
 
 // GetHost 获取主机硬件信息
@@ -216,7 +218,10 @@ func GetState(agentConfig *model.AgentConfig, skipConnectionCount bool, skipProc
 		}
 	}
 
-	go updateTemplatureStat(&temperatureStat)
+	go updateTemperatureStat()
+
+	tempWriteLock.RLock()
+	defer tempWriteLock.RUnlock()
 	ret.Temperatures = temperatureStat
 
 	go updateGPUStat(agentConfig, &gpuStat)
@@ -330,11 +335,12 @@ func updateGPUStat(agentConfig *model.AgentConfig, gpuStat *uint64) {
 	}
 }
 
-func updateTemplatureStat(tempStat *[]model.SensorTemperature) {
+func updateTemperatureStat() {
 	if !atomic.CompareAndSwapInt32(&updateTempStatus, 0, 1) {
 		return
 	}
 	defer atomic.StoreInt32(&updateTempStatus, 0)
+
 	if deviceDataFetchAttempts["Temperatures"] <= maxDeviceDataFetchAttempts {
 		temperatures, err := host.SensorsTemperatures()
 		if err != nil {
@@ -342,14 +348,19 @@ func updateTemplatureStat(tempStat *[]model.SensorTemperature) {
 			println("host.SensorsTemperatures error:", err, "attempt:", deviceDataFetchAttempts["Temperatures"])
 		} else {
 			deviceDataFetchAttempts["Temperatures"] = 0
+			tempStat := []model.SensorTemperature{}
 			for _, t := range temperatures {
 				if t.Temperature > 0 {
-					*tempStat = append(*tempStat, model.SensorTemperature{
+					tempStat = append(tempStat, model.SensorTemperature{
 						Name:        t.SensorKey,
 						Temperature: t.Temperature,
 					})
 				}
 			}
+
+			tempWriteLock.Lock()
+			defer tempWriteLock.Unlock()
+			temperatureStat = tempStat
 		}
 	}
 }