Merge pull request from GHSA-rh7j-jfvq-857j

Prevent path traversal for improved security
This commit is contained in:
iluem 2024-04-14 21:33:37 +08:00 committed by GitHub
parent ba0a8b7072
commit f77ab27bc9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -104,7 +104,15 @@ def extract_archive(file_path, dest_dir):
elif file_extension in [".tar", ".gz", ".bz2"]:
with tarfile.open(file_path, "r:*") as tarobj:
tarobj.extractall(path=dest_dir)
for member in tarobj.getmembers():
# 清理提取路径,移除任何不安全的元素
member_path = os.path.normpath(member.name)
full_path = os.path.join(dest_dir, member_path)
full_path = os.path.abspath(full_path)
if not full_path.startswith(os.path.abspath(dest_dir) + os.sep):
raise Exception(f"Attempted Path Traversal in {member.name}")
tarobj.extract(member, path=dest_dir)
print("Successfully extracted tar archive to {}".format(dest_dir))
# 第三方库需要预先pip install rarfile